From ad3f09be6cfe332be8ff46c78e6ec0f8839107aa Mon Sep 17 00:00:00 2001 From: Kemeng Shi Date: Tue, 21 Feb 2023 19:59:16 +0800 Subject: [PATCH] ext4: remove unnecessary check in ext4_bg_num_gdb_nometa We only call ext4_bg_num_gdb_nometa if there is no meta_bg feature or group does not reach first_meta_bg, so group must not reside in meta group. Then group has a global gdt if superblock exists. Just remove confusing branch that meta_bg feature exists. Signed-off-by: Kemeng Shi Link: https://lore.kernel.org/r/20230221115919.1918161-5-shikemeng@huaweicloud.com Signed-off-by: Theodore Ts'o --- fs/ext4/balloc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index 9b8a32b90ddc..08f1692f7d2f 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c @@ -844,10 +844,7 @@ static unsigned long ext4_bg_num_gdb_nometa(struct super_block *sb, if (!ext4_bg_has_super(sb, group)) return 0; - if (ext4_has_feature_meta_bg(sb)) - return le32_to_cpu(EXT4_SB(sb)->s_es->s_first_meta_bg); - else - return EXT4_SB(sb)->s_gdb_count; + return EXT4_SB(sb)->s_gdb_count; } /** -- 2.39.5