]> git.dujemihanovic.xyz Git - linux.git/commit
nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet
authorRyosuke Yasuoka <ryasuoka@redhat.com>
Wed, 20 Mar 2024 00:54:10 +0000 (09:54 +0900)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Mar 2024 09:41:39 +0000 (09:41 +0000)
commitd24b03535e5eb82e025219c2f632b485409c898f
tree50176b375cc9d3592ebf2d72de88bad21e14b115
parentcba9ffdb9913dfe6be29f049ce920ce451ce7cc4
nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet

syzbot reported the following uninit-value access issue [1][2]:

nci_rx_work() parses and processes received packet. When the payload
length is zero, each message type handler reads uninitialized payload
and KMSAN detects this issue. The receipt of a packet with a zero-size
payload is considered unexpected, and therefore, such packets should be
silently discarded.

This patch resolved this issue by checking payload size before calling
each message type handler codes.

Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation")
Reported-and-tested-by: syzbot+7ea9413ea6749baf5574@syzkaller.appspotmail.com
Reported-and-tested-by: syzbot+29b5ca705d2e0f4a44d2@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=7ea9413ea6749baf5574 [1]
Closes: https://syzkaller.appspot.com/bug?extid=29b5ca705d2e0f4a44d2 [2]
Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
Reviewed-by: Jeremy Cline <jeremy@jcline.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/nfc/nci/core.c