]> git.dujemihanovic.xyz Git - linux.git/commit
tun: tun_chr_open(): correctly initialize socket uid
authorPietro Borrello <borrello@diag.uniroma1.it>
Sat, 4 Feb 2023 17:39:21 +0000 (17:39 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Feb 2023 10:16:55 +0000 (10:16 +0000)
commita096ccca6e503a5c575717ff8a36ace27510ab0a
tree110ccd5a50aa1c7f5bc239db16f7253f80e7356f
parent584f3742890e966d2f0a1f3c418c9ead70b2d99e
tun: tun_chr_open(): correctly initialize socket uid

sock_init_data() assumes that the `struct socket` passed in input is
contained in a `struct socket_alloc` allocated with sock_alloc().
However, tun_chr_open() passes a `struct socket` embedded in a `struct
tun_file` allocated with sk_alloc().
This causes a type confusion when issuing a container_of() with
SOCK_INODE() in sock_init_data() which results in assigning a wrong
sk_uid to the `struct sock` in input.
On default configuration, the type confused field overlaps with the
high 4 bytes of `struct tun_struct __rcu *tun` of `struct tun_file`,
NULL at the time of call, which makes the uid of all tun sockets 0,
i.e., the root one.
Fix the assignment by using sock_init_data_uid().

Fixes: 86741ec25462 ("net: core: Add a UID field to struct sock.")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c