]> git.dujemihanovic.xyz Git - linux.git/commit
ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error
authorIgor Pylypiv <ipylypiv@google.com>
Tue, 2 Jul 2024 02:47:31 +0000 (02:47 +0000)
committerNiklas Cassel <cassel@kernel.org>
Wed, 3 Jul 2024 08:51:41 +0000 (10:51 +0200)
commit28ab9769117ca944cb6eb537af5599aa436287a4
treee5f618be43aac4bd7c104a8f5f5af9e058b62749
parent97981926224afe17ba3e22e0c2b7dd8b516ee574
ata: libata-scsi: Honor the D_SENSE bit for CK_COND=1 and no error

SAT-5 revision 8 specification removed the text about the ANSI INCITS
431-2007 compliance which was requiring SCSI/ATA Translation (SAT) to
return descriptor format sense data for the ATA PASS-THROUGH commands
regardless of the setting of the D_SENSE bit.

Let's honor the D_SENSE bit for ATA PASS-THROUGH commands while
generating the "ATA PASS-THROUGH INFORMATION AVAILABLE" sense data.

SAT-5 revision 7
================

12.2.2.8 Fixed format sense data

Table 212 shows the fields returned in the fixed format sense data
(see SPC-5) for ATA PASS-THROUGH commands. SATLs compliant with ANSI
INCITS 431-2007, SCSI/ATA Translation (SAT) return descriptor format
sense data for the ATA PASS-THROUGH commands regardless of the setting
of the D_SENSE bit.

SAT-5 revision 8
================

12.2.2.8 Fixed format sense data

Table 211 shows the fields returned in the fixed format sense data
(see SPC-5) for ATA PASS-THROUGH commands.

Cc: stable@vger.kernel.org # 4.19+
Reported-by: Niklas Cassel <cassel@kernel.org>
Closes: https://lore.kernel.org/linux-ide/Zn1WUhmLglM4iais@ryzen.lan
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20240702024735.1152293-4-ipylypiv@google.com
Signed-off-by: Niklas Cassel <cassel@kernel.org>
drivers/ata/libata-scsi.c