]> git.dujemihanovic.xyz Git - linux.git/commit
kprobe/ftrace: bail out if ftrace was killed
authorStephen Brennan <stephen.s.brennan@oracle.com>
Wed, 1 May 2024 16:29:56 +0000 (09:29 -0700)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Wed, 15 May 2024 22:23:30 +0000 (07:23 +0900)
commit1a7d0890dd4a502a202aaec792a6c04e6e049547
tree1ef5c1732237654fddc49948aa9644070f82fcf9
parentb7bd96ec1b709f5079fd203b680261dabc0050aa
kprobe/ftrace: bail out if ftrace was killed

If an error happens in ftrace, ftrace_kill() will prevent disarming
kprobes. Eventually, the ftrace_ops associated with the kprobes will be
freed, yet the kprobes will still be active, and when triggered, they
will use the freed memory, likely resulting in a page fault and panic.

This behavior can be reproduced quite easily, by creating a kprobe and
then triggering a ftrace_kill(). For simplicity, we can simulate an
ftrace error with a kernel module like [1]:

[1]: https://github.com/brenns10/kernel_stuff/tree/master/ftrace_killer

  sudo perf probe --add commit_creds
  sudo perf trace -e probe:commit_creds
  # In another terminal
  make
  sudo insmod ftrace_killer.ko  # calls ftrace_kill(), simulating bug
  # Back to perf terminal
  # ctrl-c
  sudo perf probe --del commit_creds

After a short period, a page fault and panic would occur as the kprobe
continues to execute and uses the freed ftrace_ops. While ftrace_kill()
is supposed to be used only in extreme circumstances, it is invoked in
FTRACE_WARN_ON() and so there are many places where an unexpected bug
could be triggered, yet the system may continue operating, possibly
without the administrator noticing. If ftrace_kill() does not panic the
system, then we should do everything we can to continue operating,
rather than leave a ticking time bomb.

Link: https://lore.kernel.org/all/20240501162956.229427-1-stephen.s.brennan@oracle.com/
Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Acked-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
arch/csky/kernel/probes/ftrace.c
arch/loongarch/kernel/ftrace_dyn.c
arch/parisc/kernel/ftrace.c
arch/powerpc/kernel/kprobes-ftrace.c
arch/riscv/kernel/probes/ftrace.c
arch/s390/kernel/ftrace.c
arch/x86/kernel/kprobes/ftrace.c
include/linux/kprobes.h
kernel/kprobes.c
kernel/trace/ftrace.c