From: Chris Morgan Date: Fri, 18 Nov 2022 06:09:18 +0000 (-0800) Subject: Input: hynitron_cstxxx - initialize tmp to 0 to fix uninitialized variable issue X-Git-Tag: v6.6-pxa1908~2309^2^2~130 X-Git-Url: https://git.dujemihanovic.xyz/?a=commitdiff_plain;h=c7f43645de7895a8e90cb267a9b3c46e989d8ca6;p=linux.git Input: hynitron_cstxxx - initialize tmp to 0 to fix uninitialized variable issue In the very unlikely event the cst3xx_i2c_write() fails inside of the cst3xx_bootloader_enter() function 5 times in a row, the uninitalized value of tmp will get compared to CST3XX_BOOTLDR_CHK_VAL. Initialize the value of tmp to 0 so that in this unlikely event we are comparing 0 instead of an uninitalized variable. Fixes: 66603243f528 ("Input: add driver for Hynitron cstxxx touchscreens") Signed-off-by: Chris Morgan Reported-by: Dan Carpenter Link: https://lore.kernel.org/r/20221117195921.2291-1-macroalpha82@gmail.com Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/touchscreen/hynitron_cstxxx.c b/drivers/input/touchscreen/hynitron_cstxxx.c index 0b9a99c6f221..e86c85addb38 100644 --- a/drivers/input/touchscreen/hynitron_cstxxx.c +++ b/drivers/input/touchscreen/hynitron_cstxxx.c @@ -210,7 +210,7 @@ static int cst3xx_bootloader_enter(struct i2c_client *client) { int err; u8 retry; - u32 tmp; + u32 tmp = 0; unsigned char buf[3]; for (retry = 0; retry < 5; retry++) {