From: NeilBrown <neilb@suse.de>
Date: Fri, 12 Jun 2015 09:46:44 +0000 (+1000)
Subject: md: don't return 0 from array_state_store
X-Git-Tag: v6.6-pxa1908~21038^2~2
X-Git-Url: https://git.dujemihanovic.xyz/?a=commitdiff_plain;h=c008f1d356277a5b7561040596a073d87e56b0c8;p=linux.git

md: don't return 0 from array_state_store

Returning zero from a 'store' function is bad.
The return value should be either len length of the string
or an error.

So use 'len' if 'err' is zero.

Fixes: 6791875e2e53 ("md: make reconfig_mutex optional for writes to md sysfs files.")
Signed-off-by: NeilBrown <neilb@suse.de>
Cc: stable@vger.kernel (v4.0+)
---

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 27506302eb7a..dd59d71ade2f 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3834,7 +3834,7 @@ array_state_store(struct mddev *mddev, const char *buf, size_t len)
 				err = -EBUSY;
 		}
 		spin_unlock(&mddev->lock);
-		return err;
+		return err ?: len;
 	}
 	err = mddev_lock(mddev);
 	if (err)