From: Jack Qiu <jack.qiu@huawei.com>
Date: Tue, 31 May 2022 01:16:56 +0000 (+0800)
Subject: f2fs: optimize error handling in redirty_blocks
X-Git-Tag: v6.6-pxa1908~3200^2~26
X-Git-Url: https://git.dujemihanovic.xyz/?a=commitdiff_plain;h=a4a0e16dbf77582c4f58ab472229dd071b5c4260;p=linux.git

f2fs: optimize error handling in redirty_blocks

Current error handling is at risk of page leaks. However, we dot't seek
any failure scenarios, just use f2fs_bug_on.

Signed-off-by: Jack Qiu <jack.qiu@huawei.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index bd14cef1b08f..2d1114b0ceef 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3903,10 +3903,10 @@ static int redirty_blocks(struct inode *inode, pgoff_t page_idx, int len)
 
 	for (i = 0; i < page_len; i++, redirty_idx++) {
 		page = find_lock_page(mapping, redirty_idx);
-		if (!page) {
-			ret = -ENOMEM;
-			break;
-		}
+
+		/* It will never fail, when page has pinned above */
+		f2fs_bug_on(F2FS_I_SB(inode), !page);
+
 		set_page_dirty(page);
 		f2fs_put_page(page, 1);
 		f2fs_put_page(page, 0);