From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 13 Oct 2010 04:43:04 +0000 (+0000)
Subject: fib: remove a useless synchronize_rcu() call
X-Git-Tag: v6.6-pxa1908~33065^2~135
X-Git-Url: https://git.dujemihanovic.xyz/?a=commitdiff_plain;h=a0a4a85a15df6335e3d11f83b2ac06ebebea313f;p=linux.git

fib: remove a useless synchronize_rcu() call

fib_nl_delrule() calls synchronize_rcu() for no apparent reason,
while rtnl is held.

I suspect it was done to avoid an atomic_inc_not_zero() in
fib_rules_lookup(), which commit 7fa7cb7109d07 added anyway.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index 21698f8c49ee..1bc3f253ba6c 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -494,7 +494,6 @@ static int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg)
 			}
 		}
 
-		synchronize_rcu();
 		notify_rule_change(RTM_DELRULE, rule, ops, nlh,
 				   NETLINK_CB(skb).pid);
 		fib_rule_put(rule);