From: Tom Rix Date: Sat, 29 Apr 2023 13:46:01 +0000 (-0400) Subject: i3c: ast2600: set variable ast2600_i3c_ops storage-class-specifier to static X-Git-Tag: v6.6-pxa1908~1309^2 X-Git-Url: https://git.dujemihanovic.xyz/?a=commitdiff_plain;h=6b496a94c5905fca7879bc0dc438a47de40b7d4f;p=linux.git i3c: ast2600: set variable ast2600_i3c_ops storage-class-specifier to static smatch reports drivers/i3c/master/ast2600-i3c-master.c:121:34: warning: symbol 'ast2600_i3c_ops' was not declared. Should it be static? This variable is only used in its defining file, so it should be static. Signed-off-by: Tom Rix Reviewed-by: Jeremy Kerr Link: https://lore.kernel.org/r/20230429134601.2688558-1-trix@redhat.com Signed-off-by: Alexandre Belloni --- diff --git a/drivers/i3c/master/ast2600-i3c-master.c b/drivers/i3c/master/ast2600-i3c-master.c index b72c12c5168f..09ed19d489e9 100644 --- a/drivers/i3c/master/ast2600-i3c-master.c +++ b/drivers/i3c/master/ast2600-i3c-master.c @@ -118,7 +118,7 @@ static void ast2600_i3c_set_dat_ibi(struct dw_i3c_master *i3c, } } -const struct dw_i3c_platform_ops ast2600_i3c_ops = { +static const struct dw_i3c_platform_ops ast2600_i3c_ops = { .init = ast2600_i3c_init, .set_dat_ibi = ast2600_i3c_set_dat_ibi, };