From: Linus Torvalds Date: Sat, 18 May 2024 02:17:55 +0000 (-0700) Subject: kprobe/ftrace: fix build error due to bad function definition X-Git-Tag: v6.10-rc5-pxa1908~300 X-Git-Url: https://git.dujemihanovic.xyz/?a=commitdiff_plain;h=4b377b4868ef17b040065bd468668c707d2477a5;p=linux.git kprobe/ftrace: fix build error due to bad function definition Commit 1a7d0890dd4a ("kprobe/ftrace: bail out if ftrace was killed") introduced a bad K&R function definition, which we haven't accepted in a long long time. Gcc seems to let it slide, but clang notices with the appropriate error: kernel/kprobes.c:1140:24: error: a function declaration without a prototype is deprecated in all > 1140 | void kprobe_ftrace_kill() | ^ | void but this commit was apparently never in linux-next before it was sent upstream, so it didn't get the appropriate build test coverage. Fixes: 1a7d0890dd4a kprobe/ftrace: bail out if ftrace was killed Cc: Stephen Brennan Cc: Masami Hiramatsu (Google) Cc: Guo Ren Cc: Steven Rostedt (Google) Signed-off-by: Linus Torvalds --- diff --git a/kernel/kprobes.c b/kernel/kprobes.c index f2cea3c80cb5..6a76a8100073 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -1137,7 +1137,7 @@ static int disarm_kprobe_ftrace(struct kprobe *p) ipmodify ? &kprobe_ipmodify_enabled : &kprobe_ftrace_enabled); } -void kprobe_ftrace_kill() +void kprobe_ftrace_kill(void) { kprobe_ftrace_disabled = true; }