From: Edward Adam Davis <eadavis@qq.com>
Date: Thu, 23 Nov 2023 01:23:39 +0000 (+0800)
Subject: mptcp: fix uninit-value in mptcp_incoming_options
X-Git-Tag: v6.7-rc6-pxa1908~131^2~20
X-Git-Url: https://git.dujemihanovic.xyz/?a=commitdiff_plain;h=237ff253f2d4f6307b7b20434d7cbcc67693298b;p=linux.git

mptcp: fix uninit-value in mptcp_incoming_options

Added initialization use_ack to mptcp_parse_option().

Reported-by: syzbot+b834a6b2decad004cfa1@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index cd15ec73073e..c53914012d01 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -108,6 +108,7 @@ static void mptcp_parse_option(const struct sk_buff *skb,
 			mp_opt->suboptions |= OPTION_MPTCP_DSS;
 			mp_opt->use_map = 1;
 			mp_opt->mpc_map = 1;
+			mp_opt->use_ack = 0;
 			mp_opt->data_len = get_unaligned_be16(ptr);
 			ptr += 2;
 		}