From: Michal Kazior Date: Fri, 22 Aug 2014 12:33:15 +0000 (+0200) Subject: ath10k: update comment regarding warm reset X-Git-Tag: v6.6-pxa1908~22421^2~133^2~55^2~8 X-Git-Url: https://git.dujemihanovic.xyz/?a=commitdiff_plain;h=10d23db44a6ab4bb454228e9e97ef19455522627;p=linux.git ath10k: update comment regarding warm reset The old comment was a little out of date. HTT Rx ring is a more relevant problem when stopping transport layer. Signed-off-by: Michal Kazior Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 21f7dc3fb57e..daa38ce29c5e 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1243,11 +1243,10 @@ static void ath10k_pci_hif_stop(struct ath10k *ar) ath10k_pci_irq_disable(ar); ath10k_pci_flush(ar); - /* Make the sure the device won't access any structures on the host by - * resetting it. The device was fed with PCI CE ringbuffer - * configuration during init. If ringbuffers are freed and the device - * were to access them this could lead to memory corruption on the - * host. */ + /* Most likely the device has HTT Rx ring configured. The only way to + * prevent the device from accessing (and possible corrupting) host + * memory is to reset the chip now. + */ ath10k_pci_warm_reset(ar); ar_pci->started = 0;