]> git.dujemihanovic.xyz Git - linux.git/commitdiff
dpaa2-eth: destroy workqueue at the end of remove function
authorDongliang Mu <mudongliangabcd@gmail.com>
Tue, 30 Nov 2021 04:05:54 +0000 (12:05 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Nov 2021 12:14:33 +0000 (12:14 +0000)
The commit c55211892f46 ("dpaa2-eth: support PTP Sync packet one-step
timestamping") forgets to destroy workqueue at the end of remove
function.

Fix this by adding destroy_workqueue before fsl_mc_portal_free and
free_netdev.

Fixes: c55211892f46 ("dpaa2-eth: support PTP Sync packet one-step timestamping")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

index 6451c8383639fcedbe61098ad3c8e244a4fd0a69..8e643567abce2a0673eb32eb3e55d3cc6c15b1bd 100644 (file)
@@ -4550,6 +4550,8 @@ static int dpaa2_eth_remove(struct fsl_mc_device *ls_dev)
 
        fsl_mc_portal_free(priv->mc_io);
 
+       destroy_workqueue(priv->dpaa2_ptp_wq);
+
        dev_dbg(net_dev->dev.parent, "Removed interface %s\n", net_dev->name);
 
        free_netdev(net_dev);