]> git.dujemihanovic.xyz Git - linux.git/commitdiff
spi: microchip-core-qspi: fix setting spi bus clock rate
authorConor Dooley <conor.dooley@microchip.com>
Wed, 8 May 2024 15:46:51 +0000 (16:46 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 9 May 2024 04:59:19 +0000 (06:59 +0200)
Before ORing the new clock rate with the control register value read
from the hardware, the existing clock rate needs to be masked off as
otherwise the existing value will interfere with the new one.

CC: stable@vger.kernel.org
Fixes: 8596124c4c1b ("spi: microchip-core-qspi: Add support for microchip fpga qspi controllers")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20240508-fox-unpiloted-b97e1535627b@spud
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-microchip-core-qspi.c

index 03d125a71fd996071c7de9ccf4c576a31d6f95bd..09f16471c53757f8144e0429f041dd66df5e1be8 100644 (file)
@@ -283,6 +283,7 @@ static int mchp_coreqspi_setup_clock(struct mchp_coreqspi *qspi, struct spi_devi
        }
 
        control = readl_relaxed(qspi->regs + REG_CONTROL);
+       control &= ~CONTROL_CLKRATE_MASK;
        control |= baud_rate_val << CONTROL_CLKRATE_SHIFT;
        writel_relaxed(control, qspi->regs + REG_CONTROL);
        control = readl_relaxed(qspi->regs + REG_CONTROL);