]> git.dujemihanovic.xyz Git - linux.git/commitdiff
arm64: dts: qcom: sc7180: Remove superfluous "input-enable"s from trogdor
authorDouglas Anderson <dianders@chromium.org>
Thu, 23 Mar 2023 17:30:13 +0000 (10:30 -0700)
committerBjorn Andersson <andersson@kernel.org>
Fri, 7 Apr 2023 17:54:09 +0000 (10:54 -0700)
As talked about in the patch ("dt-bindings: pinctrl: qcom: tlmm should
use output-disable, not input-enable"), using "input-enable" in
pinctrl states for Qualcomm TLMM pinctrl devices was either
superfluous or there to disable a pin's output.

Looking at trogdor:
* ap_ec_int_l, fp_to_ap_irq_l, h1_ap_int_odl, p_sensor_int_l:
  Superfluous. The pins will be configured as inputs automatically by
  the Linux GPIO subsystem (presumably the reference for other OSes
  using these device trees).
* bios_flash_wp_l: Superfluous. This pin is exposed to userspace
  through the kernel's GPIO API and will be configured automatically.

That means that in none of the cases for trogdor did we need to change
"input-enable" to "output-disable" and we can just remove these
superfluous properties.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230323102605.9.I94dbc53176e8adb0d7673b7feb2368e85418f938@changeid
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi

index 1f2e1f70176144675bc8d7442b26fe810c6990ae..39100b0c1140e54d9d2a7ab195a3161a56c81a6e 100644 (file)
@@ -1206,7 +1206,6 @@ ap_spi_fp: &spi10 {
        ap_ec_int_l: ap-ec-int-l-state {
                pins = "gpio94";
                function = "gpio";
-               input-enable;
                bias-pull-up;
        };
 
@@ -1229,7 +1228,6 @@ ap_spi_fp: &spi10 {
        bios_flash_wp_l: bios-flash-wp-l-state {
                pins = "gpio66";
                function = "gpio";
-               input-enable;
                bias-disable;
        };
 
@@ -1271,7 +1269,6 @@ ap_spi_fp: &spi10 {
        fp_to_ap_irq_l: fp-to-ap-irq-l-state {
                pins = "gpio4";
                function = "gpio";
-               input-enable;
 
                /* Has external pullup */
                bias-disable;
@@ -1286,7 +1283,6 @@ ap_spi_fp: &spi10 {
        h1_ap_int_odl: h1-ap-int-odl-state {
                pins = "gpio42";
                function = "gpio";
-               input-enable;
                bias-pull-up;
        };
 
@@ -1335,7 +1331,6 @@ ap_spi_fp: &spi10 {
        p_sensor_int_l: p-sensor-int-l-state {
                pins = "gpio24";
                function = "gpio";
-               input-enable;
 
                /* Has external pullup */
                bias-disable;