]> git.dujemihanovic.xyz Git - linux.git/commitdiff
nfsd: add more info to WARN_ON_ONCE on failed callbacks
authorJeff Layton <jlayton@kernel.org>
Mon, 26 Aug 2024 12:50:11 +0000 (08:50 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Fri, 20 Sep 2024 23:31:03 +0000 (19:31 -0400)
Currently, you get the warning and stack trace, but nothing is printed
about the relevant error codes. Add that in.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4callback.c

index d756f443fc444ced1ad3b160bbd1eeb057e6eab9..dee9477cc5b52ce0bc7a7e2bafb1ffdd64caacc5 100644 (file)
@@ -1333,7 +1333,8 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
                return;
 
        if (cb->cb_status) {
-               WARN_ON_ONCE(task->tk_status);
+               WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d",
+                         cb->cb_status, task->tk_status);
                task->tk_status = cb->cb_status;
        }