]> git.dujemihanovic.xyz Git - linux.git/commitdiff
net: qede: use return from qede_flow_spec_validate_unused()
authorAsbjørn Sloth Tønnesen <ast@fiberby.net>
Fri, 3 May 2024 10:55:02 +0000 (10:55 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 7 May 2024 09:08:14 +0000 (11:08 +0200)
When calling qede_flow_spec_validate_unused() then
the return code was only used for a non-zero check,
and then -EOPNOTSUPP was returned.

qede_flow_spec_validate_unused() can currently fail with:
* -EOPNOTSUPP

This patch changes qede_flow_spec_to_rule() to use the
actual return code from qede_flow_spec_validate_unused(),
so it's no longer assumed that all errors are -EOPNOTSUPP.

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/qlogic/qede/qede_filter.c

index d5ca4bf6dba5b459999dd77cd565e257b3aae8de..07af0464eb1e3d43212ece8e11daba46434db815 100644 (file)
@@ -1979,10 +1979,11 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,
        struct ethtool_rx_flow_spec_input input = {};
        struct ethtool_rx_flow_rule *flow;
        __be16 proto;
-       int err = 0;
+       int err;
 
-       if (qede_flow_spec_validate_unused(edev, fs))
-               return -EOPNOTSUPP;
+       err = qede_flow_spec_validate_unused(edev, fs);
+       if (err)
+               return err;
 
        switch ((fs->flow_type & ~FLOW_EXT)) {
        case TCP_V4_FLOW: