]> git.dujemihanovic.xyz Git - linux.git/commitdiff
mfd: cros_ec: Simplify and clean-up cros_ec_dev_init()
authorTzung-Bi Shih <tzungbi@kernel.org>
Mon, 19 Aug 2024 10:23:26 +0000 (18:23 +0800)
committerLee Jones <lee@kernel.org>
Mon, 23 Sep 2024 15:20:53 +0000 (16:20 +0100)
Simplify cros_ec_dev_init() by the following changes:
- Get rid of label `failed_devreg`.
- Remove a redundant space and comment.
- Use `if (ret)` instead of `if (ret < 0)`.

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20240819102326.5235-1-tzungbi@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/cros_ec_dev.c

index e2aae89186795cf422590ff851b80ffe91f1ece7..55b30076763bc4f5056fbb6e604d8c0b1d32b7bc 100644 (file)
@@ -353,22 +353,17 @@ static int __init cros_ec_dev_init(void)
 {
        int ret;
 
-       ret  = class_register(&cros_class);
+       ret = class_register(&cros_class);
        if (ret) {
                pr_err(CROS_EC_DEV_NAME ": failed to register device class\n");
                return ret;
        }
 
-       /* Register the driver */
        ret = platform_driver_register(&cros_ec_dev_driver);
-       if (ret < 0) {
+       if (ret) {
                pr_warn(CROS_EC_DEV_NAME ": can't register driver: %d\n", ret);
-               goto failed_devreg;
+               class_unregister(&cros_class);
        }
-       return 0;
-
-failed_devreg:
-       class_unregister(&cros_class);
        return ret;
 }