]> git.dujemihanovic.xyz Git - linux.git/commitdiff
mm/damon/dbgfs: use '__GFP_NOWARN' for user-specified size buffer allocation
authorSeongJae Park <sj@kernel.org>
Sat, 20 Nov 2021 00:43:49 +0000 (16:43 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 20 Nov 2021 18:35:54 +0000 (10:35 -0800)
Patch series "DAMON fixes".

This patch (of 2):

DAMON users can trigger below warning in '__alloc_pages()' by invoking
write() to some DAMON debugfs files with arbitrarily high count
argument, because DAMON debugfs interface allocates some buffers based
on the user-specified 'count'.

        if (unlikely(order >= MAX_ORDER)) {
                WARN_ON_ONCE(!(gfp & __GFP_NOWARN));
                return NULL;
        }

Because the DAMON debugfs interface code checks failure of the
'kmalloc()', this commit simply suppresses the warnings by adding
'__GFP_NOWARN' flag.

Link: https://lkml.kernel.org/r/20211110145758.16558-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20211110145758.16558-2-sj@kernel.org
Fixes: 4bc05954d007 ("mm/damon: implement a debugfs-based user space interface")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/damon/dbgfs.c

index eccc14b3490132baef9169bbefc5f6349e10ea35..8ce1311ac5338267fd56134fb9e6b857f66ef43a 100644 (file)
@@ -32,7 +32,7 @@ static char *user_input_str(const char __user *buf, size_t count, loff_t *ppos)
        if (*ppos)
                return ERR_PTR(-EINVAL);
 
-       kbuf = kmalloc(count + 1, GFP_KERNEL);
+       kbuf = kmalloc(count + 1, GFP_KERNEL | __GFP_NOWARN);
        if (!kbuf)
                return ERR_PTR(-ENOMEM);
 
@@ -133,7 +133,7 @@ static ssize_t dbgfs_schemes_read(struct file *file, char __user *buf,
        char *kbuf;
        ssize_t len;
 
-       kbuf = kmalloc(count, GFP_KERNEL);
+       kbuf = kmalloc(count, GFP_KERNEL | __GFP_NOWARN);
        if (!kbuf)
                return -ENOMEM;
 
@@ -452,7 +452,7 @@ static ssize_t dbgfs_init_regions_read(struct file *file, char __user *buf,
        char *kbuf;
        ssize_t len;
 
-       kbuf = kmalloc(count, GFP_KERNEL);
+       kbuf = kmalloc(count, GFP_KERNEL | __GFP_NOWARN);
        if (!kbuf)
                return -ENOMEM;
 
@@ -578,7 +578,7 @@ static ssize_t dbgfs_kdamond_pid_read(struct file *file,
        char *kbuf;
        ssize_t len;
 
-       kbuf = kmalloc(count, GFP_KERNEL);
+       kbuf = kmalloc(count, GFP_KERNEL | __GFP_NOWARN);
        if (!kbuf)
                return -ENOMEM;