]> git.dujemihanovic.xyz Git - linux.git/commitdiff
net: qede: propagate extack through qede_flow_spec_validate()
authorAsbjørn Sloth Tønnesen <ast@fiberby.net>
Wed, 8 May 2024 14:34:01 +0000 (14:34 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 May 2024 02:30:00 +0000 (19:30 -0700)
Pass extack to qede_flow_spec_validate() when called in
qede_flow_spec_to_rule().

Pass extack to qede_parse_actions().

Not converting qede_flow_spec_validate() to use extack for
errors, as it's only called from qede_flow_spec_to_rule(),
where extack is faked into a DP_NOTICE anyway, so opting to
keep DP_VERBOSE/DP_NOTICE usage.

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508143404.95901-14-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qede/qede_filter.c

index b83432744a038c4c3746c5583af0003e1c4b724b..e616855d88914ce64d0c9160e544727619c8a3fb 100644 (file)
@@ -1953,7 +1953,8 @@ unlock:
 static int qede_flow_spec_validate(struct qede_dev *edev,
                                   struct flow_action *flow_action,
                                   struct qede_arfs_tuple *t,
-                                  __u32 location)
+                                  __u32 location,
+                                  struct netlink_ext_ack *extack)
 {
        int err;
 
@@ -1977,7 +1978,7 @@ static int qede_flow_spec_validate(struct qede_dev *edev,
                return -EINVAL;
        }
 
-       err = qede_parse_actions(edev, flow_action, NULL);
+       err = qede_parse_actions(edev, flow_action, extack);
        if (err)
                return err;
 
@@ -2024,7 +2025,7 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,
 
        /* Make sure location is valid and filter isn't already set */
        err = qede_flow_spec_validate(edev, &flow->rule->action, t,
-                                     fs->location);
+                                     fs->location, &extack);
 err_out:
        if (extack._msg)
                DP_NOTICE(edev, "%s\n", extack._msg);