]> git.dujemihanovic.xyz Git - linux.git/commitdiff
arch/sparc: remove unused varible paddrbase in function leon_swprobe()
authorAlex Shi <alexs@kernel.org>
Mon, 29 Jul 2024 06:49:26 +0000 (14:49 +0800)
committerAndreas Larsson <andreas@gaisler.com>
Fri, 13 Sep 2024 18:12:11 +0000 (20:12 +0200)
commit f22ed71cd602 ("sparc32,leon: SRMMU MMU Table probe fix") change
return value from paddrbase to 'pte', but left the varible here.
That causes a build warning for this varible, so we may remove it.

make --keep-going CROSS_COMPILE=/home/alexs/0day/gcc-14.1.0-nolibc/sparc-linux/bin/sparc-linux- --jobs=16 KCFLAGS= -Wtautological-compare -Wno-error=return-type -Wreturn-type -Wcast-function-type -funsigned-char -Wundef -fstrict-flex-arrays=3 -Wformat-overflow -Wformat-truncation -Wrestrict -Wenum-conversion W=1 O=sparc ARCH=sparc defconfig SHELL=/bin/bash arch/sparc/mm/ mm/ -s
<stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
../arch/sparc/mm/leon_mm.c: In function 'leon_swprobe':
../arch/sparc/mm/leon_mm.c:42:32: warning: variable 'paddrbase' set but not used [-Wunused-but-set-variable]
   42 |         unsigned int lvl, pte, paddrbase;
      |                                ^~~~~~~~~

Signed-off-by: Alex Shi <alexs@kernel.org>
To: linux-kernel@vger.kernel.org
To: sparclinux@vger.kernel.org
To: Christian Brauner <brauner@kernel.org>
To: Andreas Larsson <andreas@gaisler.com>
To: David S. Miller <davem@davemloft.net>
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Tested-by: Andreas Larsson <andreas@gaisler.com>
Link: https://lore.kernel.org/r/20240729064926.3126528-1-alexs@kernel.org
Signed-off-by: Andreas Larsson <andreas@gaisler.com>
arch/sparc/mm/leon_mm.c

index ec61ff1f96b71a364116330c532d543eb6f3c2d4..1dc9b3d70eda7c6ae0c1c46e81d870cb4abb64f5 100644 (file)
@@ -39,12 +39,10 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)
        unsigned int ctxtbl;
        unsigned int pgd, pmd, ped;
        unsigned int ptr;
-       unsigned int lvl, pte, paddrbase;
+       unsigned int lvl, pte;
        unsigned int ctx;
        unsigned int paddr_calc;
 
-       paddrbase = 0;
-
        if (srmmu_swprobe_trace)
                printk(KERN_INFO "swprobe: trace on\n");
 
@@ -73,7 +71,6 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)
                        printk(KERN_INFO "swprobe: pgd is entry level 3\n");
                lvl = 3;
                pte = pgd;
-               paddrbase = pgd & _SRMMU_PTE_PMASK_LEON;
                goto ready;
        }
        if (((pgd & SRMMU_ET_MASK) != SRMMU_ET_PTD)) {
@@ -96,7 +93,6 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)
                        printk(KERN_INFO "swprobe: pmd is entry level 2\n");
                lvl = 2;
                pte = pmd;
-               paddrbase = pmd & _SRMMU_PTE_PMASK_LEON;
                goto ready;
        }
        if (((pmd & SRMMU_ET_MASK) != SRMMU_ET_PTD)) {
@@ -124,7 +120,6 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)
                        printk(KERN_INFO "swprobe: ped is entry level 1\n");
                lvl = 1;
                pte = ped;
-               paddrbase = ped & _SRMMU_PTE_PMASK_LEON;
                goto ready;
        }
        if (((ped & SRMMU_ET_MASK) != SRMMU_ET_PTD)) {
@@ -147,7 +142,6 @@ unsigned long leon_swprobe(unsigned long vaddr, unsigned long *paddr)
                        printk(KERN_INFO "swprobe: ptr is entry level 0\n");
                lvl = 0;
                pte = ptr;
-               paddrbase = ptr & _SRMMU_PTE_PMASK_LEON;
                goto ready;
        }
        if (srmmu_swprobe_trace)