]> git.dujemihanovic.xyz Git - linux.git/commitdiff
pwm: Fix setting period with #pwm-cells = <1> and of_pwm_single_xlate() v6.9-rc1-pxa1908
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 29 Mar 2024 10:35:40 +0000 (11:35 +0100)
committerKarel Balej <balejk@matfyz.cz>
Fri, 29 Mar 2024 10:42:27 +0000 (11:42 +0100)
For drivers making use of of_pwm_single_xlate() (i.e. those that don't
pass a hwpwm index) and also don't pass flags, setting period was
wrongly skipped. This affects the pwm-pxa and ti-sn65dsi86 drivers.

Reported-by: Karel Balej <balejk@matfyz.cz>
Fixes: 40ade0c2e794 ("pwm: Let the of_xlate callbacks accept references without period")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
drivers/pwm/core.c

index d70f793ce4b38dd7bfb20c0d44392b018ab784ea..403525cc17833c18271d555e1469814845ddd45d 100644 (file)
@@ -443,7 +443,7 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args)
        if (IS_ERR(pwm))
                return pwm;
 
-       if (args->args_count > 1)
+       if (args->args_count > 0)
                pwm->args.period = args->args[0];
 
        pwm->args.polarity = PWM_POLARITY_NORMAL;