]> git.dujemihanovic.xyz Git - linux.git/commitdiff
arm64: dts: allwinner: a64: sopine-baseboard: Add PHY regulator delay
authorJernej Skrabec <jernej.skrabec@siol.net>
Sun, 29 Sep 2019 08:52:59 +0000 (10:52 +0200)
committerMaxime Ripard <mripard@kernel.org>
Mon, 30 Sep 2019 20:12:03 +0000 (22:12 +0200)
It turns out that sopine-baseboard needs same fix as pine64-plus
for ethernet PHY. Here too Realtek ethernet PHY chip needs additional
power on delay to properly initialize. Datasheet mentions that chip
needs 30 ms to be properly powered on and that it needs some more time
to be initialized.

Fix that by adding 100ms ramp delay to regulator responsible for
powering PHY.

Note that issue was found out and fix tested on pine64-lts, but it's
basically the same as sopine-baseboard, only layout and connectors
differ.

Fixes: bdfe4cebea11 ("arm64: allwinner: a64: add Ethernet PHY regulator for several boards")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts

index e6fb9683f21355ea7e3a947b20b3ea4fc7900d61..25099202c52c99d37b06ca3127dcc9b9b8214b4b 100644 (file)
 };
 
 &reg_dc1sw {
+       /*
+        * Ethernet PHY needs 30ms to properly power up and some more
+        * to initialize. 100ms should be plenty of time to finish
+        * whole process.
+        */
+       regulator-enable-ramp-delay = <100000>;
        regulator-name = "vcc-phy";
 };