]> git.dujemihanovic.xyz Git - linux.git/commitdiff
net/mlx5: Lag, fix a potential Oops with mlx5_lag_create_definer()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 10 Nov 2021 08:07:06 +0000 (11:07 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 Nov 2021 14:43:20 +0000 (14:43 +0000)
There is a minus character missing from ERR_PTR(ENOMEM) so if this
allocation fails it will lead to an Oops in the caller.

Fixes: dc48516ec7d3 ("net/mlx5: Lag, add support to create definers for LAG")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c

index adc836b3d857ff5d9e249a74ad4051ef3311646f..ad63dd45c8fb9dbf4d401e16c35f5343b41af857 100644 (file)
@@ -289,7 +289,7 @@ mlx5_lag_create_definer(struct mlx5_lag *ldev, enum netdev_lag_hash hash,
 
        lag_definer = kzalloc(sizeof(*lag_definer), GFP_KERNEL);
        if (!lag_definer)
-               return ERR_PTR(ENOMEM);
+               return ERR_PTR(-ENOMEM);
 
        match_definer_mask = kvzalloc(MLX5_FLD_SZ_BYTES(match_definer,
                                                        match_mask),