]> git.dujemihanovic.xyz Git - linux.git/commitdiff
pwm: stm32: Refuse too small period requests
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Fri, 21 Jun 2024 14:37:12 +0000 (16:37 +0200)
committerUwe Kleine-König <ukleinek@kernel.org>
Fri, 21 Jun 2024 14:39:34 +0000 (16:39 +0200)
If period_ns is small, prd might well become 0. Catch that case because
otherwise with

regmap_write(priv->regmap, TIM_ARR, prd - 1);

a few lines down quite a big period is configured.

Fixes: 7edf7369205b ("pwm: Add driver for STM32 plaftorm")
Cc: stable@vger.kernel.org
Reviewed-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/b86f62f099983646f97eeb6bfc0117bb2d0c340d.1718979150.git.u.kleine-koenig@baylibre.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/pwm-stm32.c

index a2f231d13a9f7caca0ee8c5cf494aa8feed3fad5..3e7b2a8e34e7ddb1cf06ea9a12b35b07a3dc8c54 100644 (file)
@@ -337,6 +337,8 @@ static int stm32_pwm_config(struct stm32_pwm *priv, unsigned int ch,
 
        prd = mul_u64_u64_div_u64(period_ns, clk_get_rate(priv->clk),
                                  (u64)NSEC_PER_SEC * (prescaler + 1));
+       if (!prd)
+               return -EINVAL;
 
        /*
         * All channels share the same prescaler and counter so when two