]> git.dujemihanovic.xyz Git - linux.git/commitdiff
fbdev/ep93xx-fb: Output messages with fb_info() and fb_err()
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 13 Jun 2023 11:06:48 +0000 (13:06 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 27 Jun 2023 07:58:49 +0000 (09:58 +0200)
Fix cases were output helpers are called with struct fb_info.dev.
Use fb_info() and fb_err() instead.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230613110953.24176-14-tzimmermann@suse.de
drivers/video/fbdev/ep93xx-fb.c

index 376ee59e925c29fcf885ad9172a4f29a6c73094f..f6cd200fe50ffc2309cf05903f1f4c907ba2da71 100644 (file)
@@ -436,9 +436,9 @@ static int ep93xxfb_alloc_videomem(struct fb_info *info)
         * least.
         */
        if (check_screenpage_bug && phys_addr & (1 << 27)) {
-               dev_err(info->dev, "ep93xx framebuffer bug. phys addr (0x%x) "
-                       "has bit 27 set: cannot init framebuffer\n",
-                       phys_addr);
+               fb_err(info, "ep93xx framebuffer bug. phys addr (0x%x) "
+                      "has bit 27 set: cannot init framebuffer\n",
+                      phys_addr);
 
                dma_free_coherent(info->device, fb_size, virt_addr, phys_addr);
                return -ENOMEM;
@@ -525,7 +525,7 @@ static int ep93xxfb_probe(struct platform_device *pdev)
        err = fb_find_mode(&info->var, info, video_mode,
                           NULL, 0, NULL, 16);
        if (err == 0) {
-               dev_err(info->dev, "No suitable video mode found\n");
+               fb_err(info, "No suitable video mode found\n");
                err = -EINVAL;
                goto failed_resource;
        }
@@ -554,8 +554,8 @@ static int ep93xxfb_probe(struct platform_device *pdev)
        if (err)
                goto failed_framebuffer;
 
-       dev_info(info->dev, "registered. Mode = %dx%d-%d\n",
-                info->var.xres, info->var.yres, info->var.bits_per_pixel);
+       fb_info(info, "registered. Mode = %dx%d-%d\n",
+               info->var.xres, info->var.yres, info->var.bits_per_pixel);
        return 0;
 
 failed_framebuffer: