]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/xe: Clear all snapshot members after deleting coredump
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Wed, 21 Feb 2024 13:30:17 +0000 (14:30 +0100)
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Wed, 21 Feb 2024 19:08:20 +0000 (20:08 +0100)
It's not strictly needed to clear right now, but this prevents bugs
from dangling pointers.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Francois Dugast <francois.dugast@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240221133024.898315-2-maarten.lankhorst@linux.intel.com
drivers/gpu/drm/xe/xe_devcoredump.c

index 08d3f6cb72292b10bd97fd7970f3a03b805bdc27..ae26d8c6d01c5afcd941e1d9b7a3bf908682dca1 100644 (file)
@@ -124,6 +124,8 @@ static void xe_devcoredump_free(void *data)
                if (coredump->snapshot.hwe[i])
                        xe_hw_engine_snapshot_free(coredump->snapshot.hwe[i]);
 
+       /* To prevent stale data on next snapshot, clear everything */
+       memset(&coredump->snapshot, 0, sizeof(coredump->snapshot));
        coredump->captured = false;
        drm_info(&coredump_to_xe(coredump)->drm,
                 "Xe device coredump has been deleted.\n");