]> git.dujemihanovic.xyz Git - linux.git/commitdiff
IB/hfi1: Show fault stats in both TX and RX directions
authorMitko Haralanov <mitko.haralanov@intel.com>
Thu, 1 Feb 2018 18:52:43 +0000 (10:52 -0800)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 1 Feb 2018 22:43:31 +0000 (15:43 -0700)
The routine which shows the fault stats checks the counters
to determine whether to show any stats based on the number of
transmitted pkts/bytes for a particular opcode.

Unfortunately, it only checked the receive counters. As a result,
if any packet faults have happened for packets egressing the HFI,
those stats would not be shown.

In order to fix this, the routine is amended to also check the
TX counters. With this change the pkt/byte counts are the sum of
both TX and RX counts for the opcode.

Fixes: 1b311f8931cf ("IB/hfi1: Add tx_opcode_stats like the opcode_stats")
Reviewed-by: Don Hiatt <don.hiatt@intel.com>
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Mitko Haralanov <mitko.haralanov@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hfi1/debugfs.c

index 2e6e0c51604185e835f9eb2347825e4eeb96eb7f..852173bf05d0b7067c035358d710f748d95e3ffb 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright(c) 2015-2017 Intel Corporation.
+ * Copyright(c) 2015-2018 Intel Corporation.
  *
  * This file is provided under a dual BSD/GPLv2 license.  When using or
  * redistributing this file, you may do so under either license.
@@ -1201,6 +1201,13 @@ static int _fault_stats_seq_show(struct seq_file *s, void *v)
                }
                hfi1_rcd_put(rcd);
        }
+       for_each_possible_cpu(j) {
+               struct hfi1_opcode_stats_perctx *sp =
+                       per_cpu_ptr(dd->tx_opstats, j);
+
+               n_packets += sp->stats[i].n_packets;
+               n_bytes += sp->stats[i].n_bytes;
+       }
        if (!n_packets && !n_bytes)
                return SEQ_SKIP;
        if (!ibd->fault_opcode->n_rxfaults[i] &&