]> git.dujemihanovic.xyz Git - linux.git/commitdiff
vxlan: Add missing VNI filter counter update in arp_reduce().
authorGuillaume Nault <gnault@redhat.com>
Fri, 26 Apr 2024 15:27:19 +0000 (17:27 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Apr 2024 12:39:15 +0000 (13:39 +0100)
VXLAN stores per-VNI statistics using vxlan_vnifilter_count().
These statistics were not updated when arp_reduce() failed its
pskb_may_pull() call.

Use vxlan_vnifilter_count() to update the VNI counter when that
happens.

Fixes: 4095e0e1328a ("drivers: vxlan: vnifilter: per vni stats")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan/vxlan_core.c

index 0cd9e44c7be85face1fd3e0eeb43c432b38f4932..c9e4e03ad214f33b24e1c2d2450d151afbe8b195 100644 (file)
@@ -1838,6 +1838,8 @@ static int arp_reduce(struct net_device *dev, struct sk_buff *skb, __be32 vni)
 
        if (!pskb_may_pull(skb, arp_hdr_len(dev))) {
                dev_core_stats_tx_dropped_inc(dev);
+               vxlan_vnifilter_count(vxlan, vni, NULL,
+                                     VXLAN_VNI_STATS_TX_DROPS, 0);
                goto out;
        }
        parp = arp_hdr(skb);