powerpc/pseries: fix possible memory leak in ibmebus_bus_init()

If device_register() returns error in ibmebus_bus_init(), name of kobject
which is allocated in dev_set_name() called in device_add() is leaked.

As comment of device_add() says, it should call put_device() to drop
the reference count that was set in device_initialize() when it fails,
so the name can be freed in kobject_cleanup().

Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20221110011929.3709774-1-ruanjinjie@huawei.com

diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c
index 183aa8de48e74bcb1eb99773cfab24cc4104fa4b..998e3aff2457246a4299d140d183b14b6d69bed8 100644 (file)
--- a/arch/powerpc/platforms/pseries/ibmebus.c
+++ b/arch/powerpc/platforms/pseries/ibmebus.c
@@ -461,6 +461,7 @@ static int __init ibmebus_bus_init(void)
        if (err) {
                printk(KERN_WARNING "%s: device_register returned %i\n",
                       __func__, err);
+               put_device(&ibmebus_bus_device);
                bus_unregister(&ibmebus_bus_type);
 
                return err;