]> git.dujemihanovic.xyz Git - linux.git/commitdiff
qlcnic: make read-only const array key static
authorColin Ian King <colin.i.king@gmail.com>
Tue, 10 Sep 2024 12:06:35 +0000 (13:06 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Sep 2024 23:00:54 +0000 (16:00 -0700)
Don't populate the const read-only array key on the stack at
run time, instead make it static.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240910120635.115266-1-colin.i.king@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c

index bcef8ab715bfa1731fa7933a300f3032be824c82..d7cdea8f604d08f6c6ca2b60d724c99e72ca4587 100644 (file)
@@ -2042,12 +2042,14 @@ int qlcnic_83xx_config_hw_lro(struct qlcnic_adapter *adapter, int mode)
 
 int qlcnic_83xx_config_rss(struct qlcnic_adapter *adapter, int enable)
 {
-       int err;
-       u32 word;
        struct qlcnic_cmd_args cmd;
-       const u64 key[] = { 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
-                           0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
-                           0x255b0ec26d5a56daULL };
+       static const u64 key[] = {
+               0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
+               0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
+               0x255b0ec26d5a56daULL
+       };
+       u32 word;
+       int err;
 
        err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_CONFIGURE_RSS);
        if (err)