i3c: master: support to adjust first broadcast address speed

According to I3C spec 6.2 Timing Specification, the Open Drain High Period
of SCL Clock timing for first broadcast address should be adjusted to 200ns
at least. I3C device working as i2c device will see the broadcast to close
its Spike Filter then change to work at I3C mode. After that I3C open drain
SCL high level should be adjusted back.

Signed-off-by: Carlos Song <carlos.song@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20240910051626.4052552-1-carlos.song@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 7028f03c2c42e24b25f1339e56df2ad13abf04f2..6f3eb710a75d60f3c9104d171dcc5769f2e863c9 100644 (file)
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -1868,6 +1868,12 @@ static int i3c_master_bus_init(struct i3c_master_controller *master)
                goto err_bus_cleanup;
        }
 
+       if (master->ops->set_speed) {
+               ret = master->ops->set_speed(master, I3C_OPEN_DRAIN_SLOW_SPEED);
+               if (ret)
+                       goto err_bus_cleanup;
+       }
+
        /*
         * Reset all dynamic address that may have been assigned before
         * (assigned by the bootloader for example).
@@ -1876,6 +1882,12 @@ static int i3c_master_bus_init(struct i3c_master_controller *master)
        if (ret && ret != I3C_ERROR_M2)
                goto err_bus_cleanup;
 
+       if (master->ops->set_speed) {
+               master->ops->set_speed(master, I3C_OPEN_DRAIN_NORMAL_SPEED);
+               if (ret)
+                       goto err_bus_cleanup;
+       }
+
        /* Disable all slave events before starting DAA. */
        ret = i3c_master_disec_locked(master, I3C_BROADCAST_ADDR,
                                      I3C_CCC_EVENT_SIR | I3C_CCC_EVENT_MR |

diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h
index 074f632868d98e2570e109e952c827e92e4e3c89..2a1ed05d5782a8fde6e41b488d1c6c9d28b5e09c 100644 (file)
--- a/include/linux/i3c/master.h
+++ b/include/linux/i3c/master.h
@@ -277,6 +277,20 @@ enum i3c_bus_mode {
        I3C_BUS_MODE_MIXED_SLOW,
 };
 
+/**
+ * enum i3c_open_drain_speed - I3C open-drain speed
+ * @I3C_OPEN_DRAIN_SLOW_SPEED: Slow open-drain speed for sending the first
+ *                             broadcast address. The first broadcast address at this speed
+ *                             will be visible to all devices on the I3C bus. I3C devices
+ *                             working in I2C mode will turn off their spike filter when
+ *                             switching into I3C mode.
+ * @I3C_OPEN_DRAIN_NORMAL_SPEED: Normal open-drain speed in I3C bus mode.
+ */
+enum i3c_open_drain_speed {
+       I3C_OPEN_DRAIN_SLOW_SPEED,
+       I3C_OPEN_DRAIN_NORMAL_SPEED,
+};
+
 /**
  * enum i3c_addr_slot_status - I3C address slot status
  * @I3C_ADDR_SLOT_FREE: address is free
@@ -436,6 +450,7 @@ struct i3c_bus {
  *                   NULL.
  * @enable_hotjoin: enable hot join event detect.
  * @disable_hotjoin: disable hot join event detect.
+ * @set_speed: adjust I3C open drain mode timing.
  */
 struct i3c_master_controller_ops {
        int (*bus_init)(struct i3c_master_controller *master);
@@ -464,6 +479,7 @@ struct i3c_master_controller_ops {
                                 struct i3c_ibi_slot *slot);
        int (*enable_hotjoin)(struct i3c_master_controller *master);
        int (*disable_hotjoin)(struct i3c_master_controller *master);
+       int (*set_speed)(struct i3c_master_controller *master, enum i3c_open_drain_speed speed);
 };
 
 /**