]> git.dujemihanovic.xyz Git - linux.git/commitdiff
vdpa/mlx5: Parallelize VQ suspend/resume for CVQ MQ command
authorDragos Tatulea <dtatulea@nvidia.com>
Fri, 16 Aug 2024 09:01:59 +0000 (12:01 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 25 Sep 2024 11:07:43 +0000 (07:07 -0400)
change_num_qps() is still suspending/resuming VQs one by one.
This change switches to parallel suspend/resume.

When increasing the number of queues the flow has changed a bit for
simplicity: the setup_vq() function will always be called before
resume_vqs(). If the VQ is initialized, setup_vq() will exit early. If
the VQ is not initialized, setup_vq() will create it and resume_vqs()
will resume it.

Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Message-Id: <20240816090159.1967650-11-dtatulea@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Eugenio PĂ©rez <eperezma@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
drivers/vdpa/mlx5/net/mlx5_vnet.c

index 8138fba7ae94aedc8736dfacc973fddf19f476d9..02b06957e0f3ffceb8d63d44b037cf45efe6247c 100644 (file)
@@ -2229,25 +2229,27 @@ static int change_num_qps(struct mlx5_vdpa_dev *mvdev, int newqps)
                if (err)
                        return err;
 
-               for (i = cur_vqs - 1; i >= new_vqs; i--) {
-                       struct mlx5_vdpa_virtqueue *mvq = &ndev->vqs[i];
-
-                       if (is_resumable(ndev))
-                               suspend_vq(ndev, mvq);
-                       else
-                               teardown_vq(ndev, mvq);
+               if (is_resumable(ndev)) {
+                       suspend_vqs(ndev, new_vqs, cur_vqs - new_vqs);
+               } else {
+                       for (i = new_vqs; i < cur_vqs; i++)
+                               teardown_vq(ndev, &ndev->vqs[i]);
                }
 
                ndev->cur_num_vqs = new_vqs;
        } else {
                ndev->cur_num_vqs = new_vqs;
-               for (i = cur_vqs; i < new_vqs; i++) {
-                       struct mlx5_vdpa_virtqueue *mvq = &ndev->vqs[i];
 
-                       err = mvq->initialized ? resume_vq(ndev, mvq) : setup_vq(ndev, mvq, true);
+               for (i = cur_vqs; i < new_vqs; i++) {
+                       err = setup_vq(ndev, &ndev->vqs[i], false);
                        if (err)
                                goto clean_added;
                }
+
+               err = resume_vqs(ndev, cur_vqs, new_vqs - cur_vqs);
+               if (err)
+                       goto clean_added;
+
                err = modify_rqt(ndev, new_vqs);
                if (err)
                        goto clean_added;