]> git.dujemihanovic.xyz Git - linux.git/commitdiff
nouveau/gsp: always free the alloc messages on r535
authorDave Airlie <airlied@gmail.com>
Fri, 22 Dec 2023 04:31:58 +0000 (14:31 +1000)
committerDave Airlie <airlied@redhat.com>
Fri, 5 Jan 2024 02:27:53 +0000 (12:27 +1000)
Fixes a memory leak seen with kmemleak.

Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231222043308.3090089-10-airlied@gmail.com
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c

index 642ce0dd0faf00008b825ff5ddd9f8f4aeb63f77..9ee58e2a0eb2ad99c198ea7a58e6e1cf02a667d0 100644 (file)
@@ -605,8 +605,7 @@ r535_gsp_rpc_rm_alloc_push(struct nvkm_gsp_object *object, void *argv, u32 repc)
                ret = repc ? rpc->params : NULL;
        }
 
-       if (ret)
-               nvkm_gsp_rpc_done(gsp, rpc);
+       nvkm_gsp_rpc_done(gsp, rpc);
 
        return ret;
 }