ice: xsk: fix txq interrupt mapping

ice_cfg_txq_interrupt() internally handles XDP Tx ring. Do not use
ice_for_each_tx_ring() in ice_qvec_cfg_msix() as this causing us to
treat XDP ring that belongs to queue vector as Tx ring and therefore
misconfiguring the interrupts.

Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel)
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c
index ee084ad80a61386a16fdad29cfe2275eae1ddab4..240a7bec242be349353be039326f9fe098f5bdbe 100644 (file)
--- a/drivers/net/ethernet/intel/ice/ice_xsk.c
+++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
@@ -110,25 +110,29 @@ ice_qvec_dis_irq(struct ice_vsi *vsi, struct ice_rx_ring *rx_ring,
  * ice_qvec_cfg_msix - Enable IRQ for given queue vector
  * @vsi: the VSI that contains queue vector
  * @q_vector: queue vector
+ * @qid: queue index
  */
 static void
-ice_qvec_cfg_msix(struct ice_vsi *vsi, struct ice_q_vector *q_vector)
+ice_qvec_cfg_msix(struct ice_vsi *vsi, struct ice_q_vector *q_vector, u16 qid)
 {
        u16 reg_idx = q_vector->reg_idx;
        struct ice_pf *pf = vsi->back;
        struct ice_hw *hw = &pf->hw;
-       struct ice_tx_ring *tx_ring;
-       struct ice_rx_ring *rx_ring;
+       int q, _qid = qid;
 
        ice_cfg_itr(hw, q_vector);
 
-       ice_for_each_tx_ring(tx_ring, q_vector->tx)
-               ice_cfg_txq_interrupt(vsi, tx_ring->reg_idx, reg_idx,
-                                     q_vector->tx.itr_idx);
+       for (q = 0; q < q_vector->num_ring_tx; q++) {
+               ice_cfg_txq_interrupt(vsi, _qid, reg_idx, q_vector->tx.itr_idx);
+               _qid++;
+       }
 
-       ice_for_each_rx_ring(rx_ring, q_vector->rx)
-               ice_cfg_rxq_interrupt(vsi, rx_ring->reg_idx, reg_idx,
-                                     q_vector->rx.itr_idx);
+       _qid = qid;
+
+       for (q = 0; q < q_vector->num_ring_rx; q++) {
+               ice_cfg_rxq_interrupt(vsi, _qid, reg_idx, q_vector->rx.itr_idx);
+               _qid++;
+       }
 
        ice_flush(hw);
 }
@@ -241,7 +245,7 @@ static int ice_qp_ena(struct ice_vsi *vsi, u16 q_idx)
                fail = err;
 
        q_vector = vsi->rx_rings[q_idx]->q_vector;
-       ice_qvec_cfg_msix(vsi, q_vector);
+       ice_qvec_cfg_msix(vsi, q_vector, q_idx);
 
        err = ice_vsi_ctrl_one_rx_ring(vsi, true, q_idx, true);
        if (!fail)