]> git.dujemihanovic.xyz Git - linux.git/commitdiff
profiling: remove stale percpu flip buffer variables
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 29 Jul 2024 23:34:17 +0000 (16:34 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 29 Jul 2024 23:34:17 +0000 (16:34 -0700)
For some reason I didn't see this issue on my arm64 or x86-64 builds,
but Stephen Rothwell reports that commit 2accfdb7eff6 ("profiling:
attempt to remove per-cpu profile flip buffer") left these static
variables around, and the powerpc build is unhappy about them:

  kernel/profile.c:52:28: warning: 'cpu_profile_flip' defined but not used [-Wunused-variable]
     52 | static DEFINE_PER_CPU(int, cpu_profile_flip);
        |                            ^~~~~~~~~~~~~~~~
  ..

So remove these stale left-over remnants too.

Fixes: 2accfdb7eff6 ("profiling: attempt to remove per-cpu profile flip buffer")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/profile.c

index 2dfb0f4e755c5fbd51ad4985243d5badc548758d..ff68d3816182aff6c901023c47a7f81291cf17ad 100644 (file)
@@ -47,12 +47,6 @@ static unsigned short int prof_shift;
 int prof_on __read_mostly;
 EXPORT_SYMBOL_GPL(prof_on);
 
-#if defined(CONFIG_SMP) && defined(CONFIG_PROC_FS)
-static DEFINE_PER_CPU(struct profile_hit *[2], cpu_profile_hits);
-static DEFINE_PER_CPU(int, cpu_profile_flip);
-static DEFINE_MUTEX(profile_flip_mutex);
-#endif /* CONFIG_SMP */
-
 int profile_setup(char *str)
 {
        static const char schedstr[] = "schedule";