]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/amd/display: Allow backlight to go below `AMDGPU_DM_DEFAULT_MIN_BACKLIGHT`
authorMario Limonciello <mario.limonciello@amd.com>
Sun, 15 Sep 2024 19:28:37 +0000 (14:28 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 18 Sep 2024 20:15:13 +0000 (16:15 -0400)
The issue with panel power savings compatibility below
`AMDGPU_DM_DEFAULT_MIN_BACKLIGHT` happens at
`AMDGPU_DM_DEFAULT_MIN_BACKLIGHT` as well.

That issue will be fixed separately, so don't prevent the backlight
brightness from going that low.

Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/amd-gfx/be04226a-a9e3-4a45-a83b-6d263c6557d8@t-8ch.de/T/#m400dee4e2fc61fe9470334d20a7c8c89c9aef44f
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 94c8d9966ec387e0b5f7aa460b8dea45d7ab1ef4..6e79028c5d7897d5636aa0bc49c790f1dd243de0 100644 (file)
@@ -4506,7 +4506,7 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm,
                int spread = caps.max_input_signal - caps.min_input_signal;
 
                if (caps.max_input_signal > AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ||
-                   caps.min_input_signal < AMDGPU_DM_DEFAULT_MIN_BACKLIGHT ||
+                   caps.min_input_signal < 0 ||
                    spread > AMDGPU_DM_DEFAULT_MAX_BACKLIGHT ||
                    spread < AMDGPU_DM_MIN_SPREAD) {
                        DRM_DEBUG_KMS("DM: Invalid backlight caps: min=%d, max=%d\n",