]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1
authorhackyzh002 <hackyzh002@gmail.com>
Wed, 19 Apr 2023 12:22:33 +0000 (20:22 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 21 Apr 2023 12:50:21 +0000 (08:50 -0400)
The type of size is unsigned int, if size is 0x40000000, there will
be an integer overflow, size will be zero after size *= sizeof(uint32_t),
will cause uninitialized memory to be referenced later.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

index d8b3c9198d33274344828ebf6edc78f5704dfb5d..a8ec5ff41fc059bb3d052a76747c11c1198eebca 100644 (file)
@@ -195,7 +195,7 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p,
        uint64_t *chunk_array_user;
        uint64_t *chunk_array;
        uint32_t uf_offset = 0;
-       unsigned int size;
+       size_t size;
        int ret;
        int i;