]> git.dujemihanovic.xyz Git - linux.git/commitdiff
net: qede: use extack in qede_parse_actions()
authorAsbjørn Sloth Tønnesen <ast@fiberby.net>
Wed, 8 May 2024 14:34:02 +0000 (14:34 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 May 2024 02:30:00 +0000 (19:30 -0700)
Convert DP_NOTICE/DP_INFO to NL_SET_ERR_MSG_MOD.

Keep edev around for use with QEDE_RSS_COUNT().

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508143404.95901-15-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qede/qede_filter.c

index e616855d88914ce64d0c9160e544727619c8a3fb..9c72febc6a4240020d2b30505bbd1ad6aaaf8c4a 100644 (file)
@@ -1671,7 +1671,7 @@ static int qede_parse_actions(struct qede_dev *edev,
        int i;
 
        if (!flow_action_has_entries(flow_action)) {
-               DP_NOTICE(edev, "No actions received\n");
+               NL_SET_ERR_MSG_MOD(extack, "No actions received");
                return -EINVAL;
        }
 
@@ -1687,7 +1687,8 @@ static int qede_parse_actions(struct qede_dev *edev,
                                break;
 
                        if (act->queue.index >= QEDE_RSS_COUNT(edev)) {
-                               DP_INFO(edev, "Queue out-of-bounds\n");
+                               NL_SET_ERR_MSG_MOD(extack,
+                                                  "Queue out-of-bounds");
                                return -EINVAL;
                        }
                        break;