]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/i915/dg2: Correct DSS check for Wa_1308578152
authorMatt Roper <matthew.d.roper@intel.com>
Tue, 7 Jun 2022 15:47:24 +0000 (08:47 -0700)
committerMatt Roper <matthew.d.roper@intel.com>
Wed, 8 Jun 2022 00:51:54 +0000 (17:51 -0700)
When converting our DSS masks to bitmaps, we fumbled the condition used
to check whether any DSS are present in the first gslice.  Since
intel_sseu_find_first_xehp_dss() returns a 0-based number, we need a >=
condition rather than >.

Fixes: b87d39019651 ("drm/i915/sseu: Disassociate internal subslice mask representation from uapi")
Reported-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Acked-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220607154724.3155521-1-matthew.d.roper@intel.com
drivers/gpu/drm/i915/gt/intel_workarounds.c

index 1e7ca3863f207fb0db6fdf331f782e087e7aacb6..0ac7f5daacc42631952c195c9a821cf9730d4eec 100644 (file)
@@ -2062,7 +2062,7 @@ engine_fake_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 
 static bool needs_wa_1308578152(struct intel_engine_cs *engine)
 {
-       return intel_sseu_find_first_xehp_dss(&engine->gt->info.sseu, 0, 0) >
+       return intel_sseu_find_first_xehp_dss(&engine->gt->info.sseu, 0, 0) >=
                GEN_DSS_PER_GSLICE;
 }