]> git.dujemihanovic.xyz Git - linux.git/commitdiff
RDMA/nldev: Add missing break in rdma_nl_notify_err_msg()
authorNathan Chancellor <nathan@kernel.org>
Mon, 16 Sep 2024 13:24:34 +0000 (06:24 -0700)
committerLeon Romanovsky <leon@kernel.org>
Mon, 16 Sep 2024 17:28:40 +0000 (20:28 +0300)
Clang warns (or errors with CONFIG_WERROR=y):

  drivers/infiniband/core/nldev.c:2795:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
   2795 |         default:
        |         ^

Clang is a little more pedantic than GCC, which does not warn when
falling through to a case that is just break or return. Clang's version
is more in line with the kernel's own stance in deprecated.rst, which
states that all switch/case blocks must end in either break,
fallthrough, continue, goto, or return. Add the missing break to silence
the warning.

Fixes: 9cbed5aab5ae ("RDMA/nldev: Add support for RDMA monitoring")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://patch.msgid.link/20240916-rdma-fix-clang-fallthrough-nl_notify_err_msg-v1-1-89de6a7423f1@kernel.org
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/core/nldev.c

index 10b1411ac53d8e9c89b6705659e772eb84f4c923..39f89a4b86498220ec30bcb16bcc804f2b049752 100644 (file)
@@ -2792,6 +2792,7 @@ static void rdma_nl_notify_err_msg(struct ib_device *device, u32 port_num,
                dev_warn_ratelimited(&device->dev,
                                     "Failed to send RDMA monitor netdev detach event: port %d\n",
                                     port_num);
+               break;
        default:
                break;
        }