]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/amd: Convert SMUv13 microcode to use `amdgpu_ucode_ip_version_decode`
authorMario Limonciello <mario.limonciello@amd.com>
Wed, 28 Dec 2022 07:21:18 +0000 (01:21 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 9 Jan 2023 21:27:51 +0000 (16:27 -0500)
The special case for the one dGPU has been moved into
`amdgpu_ucode_ip_version_decode`, so simplify this code.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c

index 8bc70ed7ed003f79ea4fd90282a59cce40e9199d..f986c7bf943da8de4b2bccb57c94604be2886e86 100644 (file)
@@ -88,7 +88,6 @@ static const int link_speed[] = {25, 50, 80, 160};
 int smu_v13_0_init_microcode(struct smu_context *smu)
 {
        struct amdgpu_device *adev = smu->adev;
-       const char *chip_name;
        char fw_name[30];
        char ucode_prefix[30];
        int err = 0;
@@ -100,16 +99,9 @@ int smu_v13_0_init_microcode(struct smu_context *smu)
        if (amdgpu_sriov_vf(adev))
                return 0;
 
-       switch (adev->ip_versions[MP1_HWIP][0]) {
-       case IP_VERSION(13, 0, 2):
-               chip_name = "aldebaran_smc";
-               break;
-       default:
-               amdgpu_ucode_ip_version_decode(adev, MP1_HWIP, ucode_prefix, sizeof(ucode_prefix));
-               chip_name = ucode_prefix;
-       }
+       amdgpu_ucode_ip_version_decode(adev, MP1_HWIP, ucode_prefix, sizeof(ucode_prefix));
 
-       snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", chip_name);
+       snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix);
 
        err = request_firmware(&adev->pm.fw, fw_name, adev->dev);
        if (err)