]> git.dujemihanovic.xyz Git - linux.git/commitdiff
fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT
authorThomas Zimmermann <tzimmermann@suse.de>
Sat, 15 Jul 2023 18:51:58 +0000 (20:51 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 24 Jul 2023 14:50:39 +0000 (16:50 +0200)
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not
set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-17-tzimmermann@suse.de
drivers/video/fbdev/pxafb.c

index c8c4677d06b453a842bc7fa96d4d158c19220beb..beffb0602a2c21849787f2a571999ac1b4253445 100644 (file)
@@ -888,7 +888,6 @@ static void init_pxafb_overlay(struct pxafb_info *fbi, struct pxafb_layer *ofb,
        ofb->fb.var.vmode               = FB_VMODE_NONINTERLACED;
 
        ofb->fb.fbops                   = &overlay_fb_ops;
-       ofb->fb.flags                   = FBINFO_FLAG_DEFAULT;
        ofb->fb.node                    = -1;
        ofb->fb.pseudo_palette          = NULL;