]> git.dujemihanovic.xyz Git - linux.git/commitdiff
net: qede: use extack in qede_set_v6_tuple_to_profile()
authorAsbjørn Sloth Tønnesen <ast@fiberby.net>
Wed, 8 May 2024 14:33:50 +0000 (14:33 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 May 2024 02:29:59 +0000 (19:29 -0700)
Convert qede_set_v6_tuple_to_profile() to take extack,
and drop the edev argument.

Convert DP_INFO call to use NL_SET_ERR_MSG_MOD instead.

In calls to qede_set_v6_tuple_to_profile(), use NULL as extack
for now, until a subsequent patch makes extack available.

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508143404.95901-3-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qede/qede_filter.c

index 600b7dc7ad5646c09ee1751086c375eb83cad947..0f951d00b10ec81531248d67293759f387ebccf2 100644 (file)
@@ -1549,9 +1549,9 @@ static int qede_set_v4_tuple_to_profile(struct qede_dev *edev,
        return 0;
 }
 
-static int qede_set_v6_tuple_to_profile(struct qede_dev *edev,
-                                       struct qede_arfs_tuple *t,
-                                       struct in6_addr *zaddr)
+static int qede_set_v6_tuple_to_profile(struct qede_arfs_tuple *t,
+                                       struct in6_addr *zaddr,
+                                       struct netlink_ext_ack *extack)
 {
        /* We must have Only 4-tuples/l4 port/src ip/dst ip
         * as an input.
@@ -1573,7 +1573,7 @@ static int qede_set_v6_tuple_to_profile(struct qede_dev *edev,
                   !memcmp(&t->src_ipv6, zaddr, sizeof(struct in6_addr))) {
                t->mode = QED_FILTER_CONFIG_MODE_IP_DEST;
        } else {
-               DP_INFO(edev, "Invalid N-tuple\n");
+               NL_SET_ERR_MSG_MOD(extack, "Invalid N-tuple");
                return -EOPNOTSUPP;
        }
 
@@ -1752,7 +1752,7 @@ qede_flow_parse_v6_common(struct qede_dev *edev, struct flow_rule *rule,
        if (err)
                return err;
 
-       return qede_set_v6_tuple_to_profile(edev, t, &zero_addr);
+       return qede_set_v6_tuple_to_profile(t, &zero_addr, NULL);
 }
 
 static int