]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Tue, 2 Apr 2024 10:40:40 +0000 (03:40 -0700)
committerBoris Brezillon <boris.brezillon@collabora.com>
Wed, 3 Apr 2024 07:07:57 +0000 (09:07 +0200)
The devm_drm_dev_alloc() function returns error pointers.
Update the error handling to check for error pointers instead of NULL.

Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240402104041.1689951-1-harshit.m.mogalapalli@oracle.com
drivers/gpu/drm/panthor/panthor_drv.c

index 730dd0c69cb813c0c7f0825474baa3fd8507a7a9..5e3dc701d26d4c76b453231bde94bbad04c559f1 100644 (file)
@@ -1400,7 +1400,7 @@ static int panthor_probe(struct platform_device *pdev)
 
        ptdev = devm_drm_dev_alloc(&pdev->dev, &panthor_drm_driver,
                                   struct panthor_device, base);
-       if (!ptdev)
+       if (IS_ERR(ptdev))
                return -ENOMEM;
 
        platform_set_drvdata(pdev, ptdev);