]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/amd: Disable ASPM for VI w/ all Intel systems
authorMario Limonciello <mario.limonciello@amd.com>
Fri, 20 Oct 2023 15:26:29 +0000 (10:26 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 25 Oct 2023 13:53:17 +0000 (09:53 -0400)
Originally we were quirking ASPM disabled specifically for VI when
used with Alder Lake, but it appears to have problems with Rocket
Lake as well.

Like we've done in the case of dpm for newer platforms, disable
ASPM for all Intel systems.

Cc: stable@vger.kernel.org # 5.15+
Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
Reported-and-tested-by: Paolo Gentili <paolo.gentili@canonical.com>
Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/vi.c

index 6a8494f98d3ef488659479270b8a2a5464585868..fe8ba9e9837b39e82bc94cceb5a5a4e9a88b5ee4 100644 (file)
@@ -1124,7 +1124,7 @@ static void vi_program_aspm(struct amdgpu_device *adev)
        bool bL1SS = false;
        bool bClkReqSupport = true;
 
-       if (!amdgpu_device_should_use_aspm(adev) || !amdgpu_device_aspm_support_quirk())
+       if (!amdgpu_device_should_use_aspm(adev) || !amdgpu_device_pcie_dynamic_switching_supported())
                return;
 
        if (adev->flags & AMD_IS_APU ||