]> git.dujemihanovic.xyz Git - linux.git/commitdiff
ice: add missing WRITE_ONCE when clearing ice_rx_ring::xdp_prog
authorMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Fri, 26 Jul 2024 18:17:15 +0000 (20:17 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 29 Jul 2024 15:52:29 +0000 (08:52 -0700)
It is read by data path and modified from process context on remote cpu
so it is needed to use WRITE_ONCE to clear the pointer.

Fixes: efc2214b6047 ("ice: Add support for XDP")
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel)
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_txrx.c

index 0f91e916742772ab5fdfc50ae4d7f1b1a3da55b0..8d25b69812698285215a422f5b02e2dbe460e48a 100644 (file)
@@ -456,7 +456,7 @@ void ice_free_rx_ring(struct ice_rx_ring *rx_ring)
        if (rx_ring->vsi->type == ICE_VSI_PF)
                if (xdp_rxq_info_is_reg(&rx_ring->xdp_rxq))
                        xdp_rxq_info_unreg(&rx_ring->xdp_rxq);
-       rx_ring->xdp_prog = NULL;
+       WRITE_ONCE(rx_ring->xdp_prog, NULL);
        if (rx_ring->xsk_pool) {
                kfree(rx_ring->xdp_buf);
                rx_ring->xdp_buf = NULL;