]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/xe: Remove fence check from send_tlb_invalidation
authorMatthew Brost <matthew.brost@intel.com>
Tue, 23 Jul 2024 19:07:14 +0000 (12:07 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 12 Sep 2024 14:06:16 +0000 (10:06 -0400)
'fence' argument in send_tlb_invalidation cannot be NULL, remove
non-NULL check from send_tlb_invalidation.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202407231049.esig0Fkb-lkp@intel.com/
Fixes: 58bfe6674467 ("drm/xe: Drop xe_gt_tlb_invalidation_wait")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240723190714.1744653-1-matthew.brost@intel.com
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
(cherry picked from commit 6482253e6e1ad1c3a76645a3899d3cfdb5b918cb)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c

index 481d83d07367d23df42d7fd97fbae65617bee94e..87cb76a8718c998683fc772a125ab353d43bbaeb 100644 (file)
@@ -182,7 +182,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
        action[1] = seqno;
        ret = xe_guc_ct_send_locked(&guc->ct, action, len,
                                    G2H_LEN_DW_TLB_INVALIDATE, 1);
-       if (!ret && fence) {
+       if (!ret) {
                spin_lock_irq(&gt->tlb_invalidation.pending_lock);
                /*
                 * We haven't actually published the TLB fence as per
@@ -203,7 +203,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
                                                   tlb_timeout_jiffies(gt));
                }
                spin_unlock_irq(&gt->tlb_invalidation.pending_lock);
-       } else if (ret < 0 && fence) {
+       } else if (ret < 0) {
                __invalidation_fence_signal(xe, fence);
        }
        if (!ret) {