]> git.dujemihanovic.xyz Git - linux.git/commitdiff
net: ag71xx: use ethtool_puts
authorRosen Penev <rosenp@gmail.com>
Thu, 5 Sep 2024 19:49:35 +0000 (12:49 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Sep 2024 00:17:39 +0000 (17:17 -0700)
Allows simplifying get_strings and avoids manual pointer manipulation.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://patch.msgid.link/20240905194938.8453-5-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/atheros/ag71xx.c

index 74e01ce6161f4542e4fb892b56ec98a00fd71ce3..35db6912e84580670ed0e3b74ac68f4f16b4e0b7 100644 (file)
@@ -509,8 +509,7 @@ static void ag71xx_ethtool_get_strings(struct net_device *netdev, u32 sset,
        switch (sset) {
        case ETH_SS_STATS:
                for (i = 0; i < ARRAY_SIZE(ag71xx_statistics); i++)
-                       memcpy(data + i * ETH_GSTRING_LEN,
-                              ag71xx_statistics[i].name, ETH_GSTRING_LEN);
+                       ethtool_puts(&data, ag71xx_statistics[i].name);
                break;
        case ETH_SS_TEST:
                net_selftest_get_strings(data);